Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Ditch Query helpers. #17

Merged
merged 1 commit into from
Dec 14, 2023
Merged

v2: Ditch Query helpers. #17

merged 1 commit into from
Dec 14, 2023

Conversation

jharshman
Copy link
Contributor

This PR focuses around simplification of the tsplot package. Moving away
from something that was rather perscriptive in the type of Query that
you could make and towards a package that can accept a Time Series or
Time Series Itterator from the Google Metrics API and return a rendered
graph of those Time Series.

@jharshman
Copy link
Contributor Author

test

@jharshman
Copy link
Contributor Author

Testing multiple TimeSeries graphed on a single plot.
test

@jharshman
Copy link
Contributor Author

Looks similar enough to the GCM plot
image

@jharshman
Copy link
Contributor Author

test

@jharshman
Copy link
Contributor Author

Okay there are a few tasks left on this -

The first is that the function that returns colors for the lines can return colors that are very very hard to see.
The second is that the createLine function doesn't work for int64 values.

@jharshman
Copy link
Contributor Author

decodes

This PR focuses around simplification of the tsplot package. Moving away
from something that was rather perscriptive in the type of Query that
you could make and towards a package that can accept a Time Series or
Time Series Itterator from the Google Metrics API and return a rendered
graph of those Time Series.
@myshkins
Copy link
Contributor

LGTM! 👍

@jharshman jharshman merged commit 047e30c into bitly:master Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants